----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/316/#review505 -----------------------------------------------------------
src/base/inet.cc <http://reviews.m5sim.org/r/316/#comment739> I don't see how this works. after the first nibble, wont everything be 0? - Ali On 2010-11-20 23:40:22, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/316/ > ----------------------------------------------------------- > > (Updated 2010-11-20 23:40:22) > > > Review request for Default. > > > Summary > ------- > > Params: Add parameter types for IP addresses in various forms. > > New parameter forms are: > IP address in the format "a.b.c.d" where a-d are from decimal 0 to 255. > IP address with netmask which is an IP followed by "/n" where n is a netmask > length in bits from decimal 0 to 32 or by "/e.f.g.h" where e-h are from > decimal 0 to 255 and which is all 1 bits followed by all 0 bits when > represented in binary. These can also be specified as an integral IP and > netmask passed in separately. > IP address with port which is an IP followed by ":p" where p is a port index > from decimal 0 to 65535. These can also be specified as an integral IP and > port value passed in separately. > > > Diffs > ----- > > src/base/inet.hh bf5377d8f5c1 > src/base/inet.cc bf5377d8f5c1 > src/python/m5/params.py bf5377d8f5c1 > src/python/m5/util/convert.py bf5377d8f5c1 > src/python/swig/inet.i bf5377d8f5c1 > > Diff: http://reviews.m5sim.org/r/316/diff > > > Testing > ------- > > > Thanks, > > Gabe > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
