----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/336/ -----------------------------------------------------------
(Updated 2010-12-21 19:43:15.419690) Review request for Default. Changes ------- I have made some changes. While testing the changes that I have been making to Ruby, the deadlock detected message popped. The following data was not pretty useful. I realized that it is so because I have made some changes to the message that is sent to output. WARN prints the variable name as well. So I have added to those to the panic() statements. Brad, take a look if these changes seem fine to you. I ran the regression tester for quick tests. Summary ------- This patch removes the WARN_* and ERROR_* from src/mem/ruby/common/Debug.hh file. These statements have been replaced with warn(), panic() and fatal() defined in src/base/misc.hh Diffs (updated) ----- src/cpu/testers/rubytest/Check.cc 998b217dcae7 src/cpu/testers/rubytest/CheckTable.cc 998b217dcae7 src/cpu/testers/rubytest/RubyTester.cc 998b217dcae7 src/mem/protocol/RubySlicc_Util.sm 998b217dcae7 src/mem/ruby/buffers/MessageBuffer.cc 998b217dcae7 src/mem/ruby/common/Debug.hh 998b217dcae7 src/mem/ruby/common/NetDest.cc 998b217dcae7 src/mem/ruby/common/Set.cc 998b217dcae7 src/mem/ruby/network/Network.cc 998b217dcae7 src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc 998b217dcae7 src/mem/ruby/network/garnet/fixed-pipeline/NetworkInterface_d.cc 998b217dcae7 src/mem/ruby/network/garnet/fixed-pipeline/RoutingUnit_d.cc 998b217dcae7 src/mem/ruby/network/garnet/fixed-pipeline/SWallocator_d.cc 998b217dcae7 src/mem/ruby/network/garnet/fixed-pipeline/VCallocator_d.cc 998b217dcae7 src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc 998b217dcae7 src/mem/ruby/slicc_interface/RubySlicc_ComponentMapping.hh 998b217dcae7 src/mem/ruby/slicc_interface/RubySlicc_Util.hh 998b217dcae7 src/mem/ruby/storebuffer/storebuffer.cc 998b217dcae7 src/mem/ruby/system/CacheMemory.cc 998b217dcae7 src/mem/ruby/system/PerfectCacheMemory.hh 998b217dcae7 src/mem/ruby/system/Sequencer.cc 998b217dcae7 src/mem/ruby/tester/DeterministicDriver.cc 998b217dcae7 src/mem/ruby/tester/RaceyPseudoThread.cc 998b217dcae7 src/mem/ruby/tester/test_framework.cc 998b217dcae7 src/mem/slicc/symbols/StateMachine.py 998b217dcae7 src/mem/slicc/symbols/Type.py 998b217dcae7 Diff: http://reviews.m5sim.org/r/336/diff Testing ------- Thanks, Nilay
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
