I looked at that too, and while the grouping is mentioned and the order seems to be implied (but not mentioned) the spacing doesn't seem to even be implied. This change itself isn't a big deal, even though in a perfect world it would be best to get rid of the whitespace only changes. The thing that worries me the most is that if this becomes part of an automated check, the spacing could be required which seems a little draconian to me, especially since it's at best hinted at by the style guide and nobody but Nate seems to have known about it.
Gabe Steve Reinhardt wrote: > I had to look it up, but Nate's right, the spacing is part of the > official style (and I checked to verify he didn't just add this to the > wiki either): > http://m5sim.org/wiki/index.php/Coding_Style#.23includes > > So I'd have to agree with Nate that even though normally we'd not want > csets that just add or remove whitespace, in this case they are part > of making existing code match the official style, so it seems > appropriate to me. > > Steve > > ------------------------------------------------------------------------ > > _______________________________________________ > m5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/m5-dev > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
