I mean that it's not implied that there's exactly one blank line which his script enforces. If there are two lines, one is deleted. I would claim that the fact that there are blank lines at all could be looked at as a way to make the comments stand out in the particular text on the wiki, although in many circumstances it would be good to have the spacing.
Gabe Steve Reinhardt wrote: > The spacing is definitely implied, since there are actual spaces > between the groups in the example... I agree that we don't want to go > overboard on strict rules, but if we're going to have groups, then > having spacing between them makes sense to me. > > I don't have really strong feelings about include ordering myself, > though it is nice to have some convention. I certainly don't have > strong enough feelings to stop Nate from running his script if he wants. > > Steve > > On Sun, Dec 26, 2010 at 11:31 PM, Gabe Black <[email protected] > <mailto:[email protected]>> wrote: > > I looked at that too, and while the grouping is mentioned and the > order > seems to be implied (but not mentioned) the spacing doesn't seem > to even > be implied. This change itself isn't a big deal, even though in a > perfect world it would be best to get rid of the whitespace only > changes. The thing that worries me the most is that if this > becomes part > of an automated check, the spacing could be required which seems a > little draconian to me, especially since it's at best hinted at by the > style guide and nobody but Nate seems to have known about it. > > Gabe > > Steve Reinhardt wrote: > > I had to look it up, but Nate's right, the spacing is part of the > > official style (and I checked to verify he didn't just add this > to the > > wiki either): > > http://m5sim.org/wiki/index.php/Coding_Style#.23includes > > > > So I'd have to agree with Nate that even though normally we'd > not want > > csets that just add or remove whitespace, in this case they are part > > of making existing code match the official style, so it seems > > appropriate to me. > > > > Steve > > > > > ------------------------------------------------------------------------ > > > > _______________________________________________ > > m5-dev mailing list > > [email protected] <mailto:[email protected]> > > http://m5sim.org/mailman/listinfo/m5-dev > > > > _______________________________________________ > m5-dev mailing list > [email protected] <mailto:[email protected]> > http://m5sim.org/mailman/listinfo/m5-dev > > > ------------------------------------------------------------------------ > > _______________________________________________ > m5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/m5-dev > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
