> I mean that it's not implied that there's exactly one blank line which > his script enforces. If there are two lines, one is deleted. I would > claim that the fact that there are blank lines at all could be looked at > as a way to make the comments stand out in the particular text on the > wiki, although in many circumstances it would be good to have the spacing.
Is there a particular reason that you care about this so much or are you simply bikeshedding? Do you oppose sorted includes? This is a pretty common concept and makes it much easier to find an include among many when you're hacking on a file. (My script found a number of duplicates). If you're not opposed to sorting, do you not find it nice to have a script that fixes include ordering across the entire source tree? I like it because if you do something simple like rename a file or a directory (which I have done), then you can just do a regex search/replace, run the script and fix it up. I've done this sort of thing many times and I've gotten pretty fed up with the fact that I had to manually fix the diff afterwards. This particular one was bad enough that I went through the trouble to write a script to fix it. The reason for enforcing spaces is two-fold. First, it makes things look better and easier to follow if the groups are separated by a single blank line. In general, you'll find that in the M5 source tree, we do not have multiple blank lines in files intentionally. The second reason is that it's just a pragmatic issue of writing the script. If someone inserted a random spacing between three groups of includes and some of the files move, where do the spaces go? This is not even trivial to answer and is certainly more difficult to code. My script does not affect whitespace before or after the #includes, and does not try to do anything when includes are separated by any non #include line except for sort them as independent groups. (i.e. it doesn't mess around by rearranging where an #ifdef is) Nate _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
