> No, I'm not disagreeing with you because I'm confused or belligerent. > I'm disagreeing with you because I think you're wrong, and I'm allowed > to do that. Sorting includes is not the issue here, the spacing is. The > hang up seems to be making life easier for the script, and while I > sympathize I am not willing to add one more silly detail I have to worry > about when I'm writing code just to make a single script happy. I > already proposed a way to write the script that should preserve the > spacing several emails ago. Use spaces and changes between types of > files as markers for groups of includes in the file, group includes by > type, sort them, and insert them at the markers without disturbing the > spacing around them. If that doesn't do it then do what you want, > because I'm tired of talking about this too.
The problem is that most files don't have any sort intelligent spacing between includes. It's just a random mess. If I did what you said, there would be a ton of messiness left in the files. It is not simply to make the script easier because what you suggest is trivial. If I did only that, the many files would still be a mess. The rules are not at all complicated, there is a clear example in the style guide, and are a pretty common throughout the tree. Only about 500 of 1827 files in the tree have any diff at all when running sort_includes, of those 500, only about 40 are whitespace only changes and the changes are not extensive throughout the file. This is not exactly a silly detail that will make your life a pain. It's not any more of a silly detail than any of our other style guidelines. Nate _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
