----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/449/#review808 -----------------------------------------------------------
src/cpu/inorder/resources/branch_predictor.cc <http://reviews.m5sim.org/r/449/#comment1128> Right here, we are trying to set the default not-taken path of the branch. We do this, because The Branch Predictor will only update the PCState if it's a taken branch... Is that violating how you (Gabe) intending PCState to work? src/cpu/inorder/resources/fetch_seq_unit.cc <http://reviews.m5sim.org/r/449/#comment1129> This code was trying to set a default prediction BUT it may be unnecessary since we are setting the default prediction (not taken) in the branch predictor any way - Korey On 2011-01-25 16:04:38, Korey Sewell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/449/ > ----------------------------------------------------------- > > (Updated 2011-01-25 16:04:38) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > inorder: pcstate and delay slots bug > For ISAs with delay slots, not taken branches were not being advanced > correctly to pc+8, so for those ISAs > we 'advance()' the pcstate one more time for the desired effect > > > Diffs > ----- > > src/cpu/inorder/resources/branch_predictor.cc 31a04e5ac4be > src/cpu/inorder/resources/fetch_seq_unit.cc 31a04e5ac4be > > Diff: http://reviews.m5sim.org/r/449/diff > > > Testing > ------- > > > Thanks, > > Korey > >
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
