Getting all the ISA_HAS_DELAY_SLOTs out the code is a worthwhile goal that I'd like to take another stab at in the near term (more than likely when I get the next ISA working in InOrder).
It seems as if the PCState had just some "default target" member function or something that could be called that would return NPC for non-delay slot ISAs and NNPC for delay slot ISAs, then it might be a little more easier to scrub out the ISA_HAS_DELAY_SLOT stuff. But for now, I'm going to tackle a few other changes and get back to that... On Thu, Feb 3, 2011 at 9:24 PM, Gabe Black <gbl...@eecs.umich.edu> wrote: > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/449/ > > Ship it! > > This looks better. It would be even better still if we could get rid of that > last ISA_HAS_DELAY_SLOT, but that might be hard to do. In O3 I made fetch > walk past skipped instructions and I think I might have even still had an > ISA_HAS_DELAY_SLOT in there. > > > - Gabe > > On February 3rd, 2011, 9:59 a.m., Korey Sewell wrote: > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > By Korey Sewell. > > *Updated 2011-02-03 09:59:35* > Description > > inorder: pcstate and delay slots bug > not taken delay slots were not being advanced correctly to pc+8, so for those > ISAs > we 'advance()' the pcstate one more time for the desired effect > > Diffs > > - src/cpu/inorder/resources/bpred_unit.cc (31a04e5ac4be) > - src/cpu/inorder/resources/branch_predictor.cc (31a04e5ac4be) > - src/cpu/inorder/resources/fetch_seq_unit.cc (31a04e5ac4be) > > View Diff <http://reviews.m5sim.org/r/449/diff/> > -- - Korey
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
