I am doing a review now. (Line 413, "SHOULD not" --> "SHOULD NOT" is all I have so far.)
And I will second Greg's comment about this format being an awesome way to view these changes -- thank you again for putting them together! -Ben On Tue, Feb 06, 2018 at 10:17:35PM +0800, Weijun Wang wrote: > I will submit a new draft tomorrow if there is no other feedback. > > Thanks > Weijun > > > On Jan 29, 2018, at 9:26 AM, Weijun Wang <weijun.w...@oracle.com> wrote: > > > > The HTML file updated in place. > > > > Thanks > > Weijun > > > >> On Jan 27, 2018, at 10:12 AM, Greg Hudson <ghud...@mit.edu> wrote: > >> > >> On 01/23/2018 06:43 PM, Weijun Wang wrote: > >>> I've uploaded an updated version at > >>> > >>> http://cr.openjdk.java.net/~weijun/rfc5653bis/draft-ietf-kitten-rfc5653bis-07.html > >> > >> This is a great format for reviewing these changes; thanks for > >> generating it. > >> > >> Line 416 does not capitalize "optional" in "optional services", but > >> lines 385 and 391 do. > >> > >> Lines 422 and 424 should probably capitalize "should". Line 429 should > >> probably capitalize "may". > >> > >> At line 598, I would lean towards leaving "MUST" in lowercase as we are > >> describing an application requirement, not prescribing one. > >> > >> Line 1174, I would leave "MAY" in lowercase. > >> > >> Line 1229, "may" should probably be capitalized. > >> > >> Line 1369, I would leave "MAY" alone as this seems more descriptive than > >> prescriptive. > >> > >> Line 3221's use of "SHOULD" is prescriptive, but there's no other way to > >> request the default QOP. So I would leave it lowercase (or change the > >> wording, but I'm not trying to open any more cans of worms). > >> > > > > _______________________________________________ > > Kitten mailing list > > kit...@ietf.org > > https://www.ietf.org/mailman/listinfo/kitten > _______________________________________________ Gen-art mailing list Gen-art@ietf.org https://www.ietf.org/mailman/listinfo/gen-art
