On Thu, Aug 18, 2011 at 8:27 AM, Fabian Groffen <grob...@gentoo.org> wrote:
> On 18-08-2011 16:57:59 +0200, Michał Górny wrote:
>> > # @ECLASS-VARIABLE: LC_PCAT
>> > # @DESCRIPTION:
>> > # Set this to the category of the plugin, if any.
>> > : ${LC_PCAT:=}
>>
>> Please use verbose variable names, and prefix them with eclass
>> filename; e.g. LEECHCRAFT_PLUGIN_CATEGORY.
>
> Really? The python eclass is full of such awkward overly verbose names.
> One can also exaggerate...
python.eclass, perhaps not the best style to use as a defense ;)
-A
>
>> > if [ "${LC_PCAT+x}" != "x" ]; then
>> > CMAKE_USE_DIR="${S}/src/plugins/${LC_PCAT}/${PN#leechcraft-}"
>> > else
>> > if [[ ${PN} != "leechcraft-core" ]]; then
>> > CMAKE_USE_DIR="${S}/src/plugins/${PN#leechcraft-}"
>> > else
>> > CMAKE_USE_DIR="${S}/src"
>> > fi
>> > fi
>>
>> if-elif-else-fi.
>
> This sounds like a kind of bogus suggestion to me. Mixing use of [ and
> [[, on the other hand, is more what deserves attention here.
>
>
>
> --
> Fabian Groffen
> Gentoo on a different level
>
>
