2011/8/18 Michał Górny <mgo...@gentoo.org>:
> On Thu, 18 Aug 2011 14:38:01 +0400
> Maxim Koltsov <maksbo...@gentoo.org> wrote:
>
>
>>       0|1) die "EAPI not supported, bug ebuild mantainer" ;;
>>       *) die "Unknown EAPI, Bug eclass maintainers." ;;
>
> I think I already mentioned that. Keep consistent case, and in this
> case lowercase 'bug' is correct'.

Sorry, i lost fixed version and forgot to correct this in new one :(

>> # @ECLASS-VARIABLE: LC_PCAT
>> # @DESCRIPTION:
>> # Set this to the category of the plugin, if any.
>> : ${LC_PCAT:=}
>
> Please use verbose variable names, and prefix them with eclass
> filename; e.g. LEECHCRAFT_PLUGIN_CATEGORY.
>
> And I think @DEFAULT_UNSET may be of interest too.
done

> if-elif-else-fi.
done

> And I think you dropped gentoo-dev@ from recipients a few mails ago.
Yes, added it now.

-- 
Regards, Maxim.

Attachment: leechcraft.eclass
Description: Binary data

Reply via email to