Andrea Aime wrote: > Mauro Bartolomeoli ha scritto: >>> So yeah... i see no reason why not to move it to an extension. We >>> can also a nice blog post about it too. The only thing at this point >>> that remains is getting it to compile in java 5. Which i can commit >>> if you approve. >> Just an additional little note: the package includes a >> ConverterFactory for Geometry to Geometry conversion >> (http://jira.codehaus.org/browse/GEOT-2147), which is used by the >> code to assure the geometry is of the correct type after a clipping >> operation. Since it's registered as a standard Converter, it will >> affect other code using Converters. Do you think this could be a >> problem? > > Right right. I looked at it briefly and I'm a little twisted. > The following conversions do not concern me, on the contrary, > we really missed them > * multi geom with just one geom to single geom > * single geom to multi geom > The ones that perform a geometry type change are a different story > thought. Shall a polygon be convertible to a point (its centroid)? > Hard question, the conversion might be exactly what you need, or > might be hiding a structural problem in the data being read. Sure, is questionable. I think I've seen some discussion in the past about ConverterFactory safe/not safe conversions, but I don't remember exactly. > > Since we have no way to differentiate, I guess I prefer to have > the conversion instead of having nothing. Can we use hints in some way to decide if "unsafe" conversions are to be performed or not? > May I ask you add log > statemets (working only at fine level) for the conversions that > are not "safe"? If we end up debbuging a problem that might be > hidden by the converters, that would help. Just committed. I added logging for any conversion to Point, LineString, Polygon except for multi geom with just one geom to single geom.
Mauro ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
