Hi Andrea, your concerns are alright, no need to apologize. Explanation bellow.
On Thursday 04 December 2008 12:40:10 Andrea Aime wrote: > Hi all, > this morning I've spotted a few changes in 2.5.x > that might affect the 1.7.1 release, as they touch > code that is probably used by the WFS module of > GeoServer. The idea is for them to affect the release _positively_, as this allows RemoteOWSTestSupport to be enabled again. I saw you closed GEOS-1547 as it targets 2.0 but I wonder if it should point to 1.7.x too since its our stable branch. That said, I realize the changeset is quite extensive but honestly I feel better with it applied than not. Rationale being that it includes all the improvements developed for the fgdc cap grant. Since the work originally started on trunk before branching 2.5, when that happened development continued on 2.6.x and the wfs module on 2.5 was left in a state of flux. For that reason I cannot have any confidence on it as it was, and also would not be able to properly support it but aligning with the stuff on trunk of which I'm confident about seems good to me maintainance wise. All in all, if it still sounds too risky I would be ok on reverting. I just think since there were no code freeze and 2.5 had an obsolete wfs it was good to have it aligned with the one we know works. Does that make sense? I'm looking forward for your opinions guys, if you feel better reverting lets do it. Cheers, Gabriel > > These are Gabriel backports of fixes that occurred > on trunk. I am a bit nervous about them since > we're days away from the release and I'd personally > prefer to have the branches treated as frozen, > as in "only critical bug fixes coming in". > > My suggestion: > - Justin, I guess you may want to call a freeze and > ask people to refrain from committing stuff to > 2.5.x and 1.7.x that's not related to the GeoServer > 1.7.1 release? (anything other than critical bug fixes, > that is) > - Gabriel, the changes that might affect the WFS module > seem to be at r31848, 31949, related to > "GEOT-2191 backport fixes on ows and wfs emf models" > I'd suggest to have them reviewed or revert them > for the time being? > > If you have already done a peer review and the changes > are considered ok please accept my apologies, I'm just > trying to make sure the 1.7.1 release is going to be solid. > > Cheers > Andrea ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
