Good points Andrea. I agree, up until this point there has been no formal rules about review, yet certain practices and conventions have been evolving. I will throw up what I think the current practices have become and throw them into a GSIP when I get a chance.
Andrea Aime wrote: > Justin Deoliveira ha scritto: >> Simone Giannecchini wrote: >>> .... and more should be on its way :-) >>> >>> I am not against this sort of babysitting, especially becausue the >>> longer the document is the worse my english gets towards the end. >>> Nevertheless I have to admit that lately I feel like I have to ask >>> permission to even do my own work. I hope this is just an impression. >> I think your impression is correct, although misphrased. No one wants >> to be the overseer or have the right to give the OK of what gets done. >> Just the right to do code review which results in much higher quality >> work. > > Justin, > I know you're big on reviews and I agree they do make for higher > quality. > > Some projects, like OL, have established rules where each commit > has to be reviewed by at least two other committers, or stuff like > that. > > I don't disagree going down that path, but imho that requires a GSIP > that is voted unanimously. It also requires a change of mind in > how promptly reviews are done (having someone stuck for weeks > or more is not good), maybe establishing a window for reviews, > and have the patch land in case of no review (just like we do > for IP in GeoTools, to avoid someone get stuck due to lack of > interest). > > Given that GoeServer lacks formal module ownership we should also > either establish some or decide that any committer that feels > entitled to review can. > > Anyways, despite the form, such governance rules should be > described and voted in a GSIP imho > > Cheers > Andrea > -- Justin Deoliveira OpenGeo - http://opengeo.org Enterprise support for open source geospatial. ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
