Hello Andrea, Please find my comments below.
Le dim. 7 nov. 2021 à 17:32, Andrea Aime <andrea.a...@geosolutionsgroup.com> a écrit : > On Thu, Nov 4, 2021 at 3:39 PM Alexandre Gacon <alexandre.ga...@gmail.com> > wrote: > >> Hi, >> >> After the recent debate on the translation of GeoServer, I have spent >> some time setting up a small project to see how the transifex-github >> integration works. >> >> First, I have created a fork of the GeoServer repo on my own GitHub >> account and created a new branch named `test_transifex` ( >> https://github.com/AlexGacon/geoserver/tree/test_transifex). >> >> Then, I have activated the transifex-github integration between my GitHub >> account and the GeoServer Transifex project (to be removed and replaced >> later if we continue this way). >> >> I have also created a new project in Transifex to avoid polluting the >> existing work of people working on translation ( >> https://www.transifex.com/GeoServer/geoservertestgithub/dashboard/). >> >> I have initiated my project with the property file of web/wms ( >> https://github.com/AlexGacon/geoserver/blob/test_transifex/src/web/wms/src/main/resources/GeoServerApplication.properties), >> with a manual upload. >> > > Manual upload? So what happens when community modules graduate, and new > resources come into existence? > The manual upload is only for initialisation of the new project. When a community module graduates with new resources, a manual setup must be done to link the module resources into Transifex. > Something automatic would be preferable I guess (the second best thing is > to have someone that will take care of it). > > >> The next step was to upload some existing translations from transifex in >> language not available in GitHub to check later the behavior of the >> integration in this case. >> >> After activation of the integration for my transifex project: >> - The main property file is synchronized on Transifex with the content >> from GitHub >> - The languages available on GitHub are visible on Transifex with the >> translation from GitHub >> - The imported languages are still visible on Transifex >> >> After manual sync from Transifex to GitHub, PRs were created in GitHub >> for each new language. >> >> As a final test, I updated in Transifex the GitHub French translation >> (54% coverage) with the one available in Transifex (more than 85% >> coverage), by downloading the translation file and then uploading it in the >> new transifex project. After manual sync request, a PR is created in GitHub >> for the new language (https://github.com/AlexGacon/geoserver/pull/7) : >> the diff result is not very clear (some lines are marked as removed and >> added whereas the content is the same). >> > > This message is cause of concern: > > "Manual sync of partially translated files: untranslated content is > included with an empty translation or source language content depending on > file format" > > I believe we don't want an empty translation, what if the wicket i18n then > decides to stick and empty string in the UI instead > of the fallback in the default language (english)? > I didn't spot this message. I checked untranslated content in my different tests: for java property files, untranslated content is provided with a copy of the source language content. > > >> Is it normal that for some languages you have unicode encoded characters >> ? (for example in Russian). >> > > There are two possibilities here: > > - Unicode escaping, Transifex seems to be going for it. > <https://github.com/AlexGacon/geoserver/pull/13/files> > - Special property files that are encoded in unicode, with an > extension ".utf8.properties". It's something that we found out Wicket > supports, but was not available due to some GeoServer customizations. Jody > fixed that and GeoServer can now use that mechanism as well. > > Transifex cannot manage the second case : all the language files for one resource must follow the same pattern. The utf8 properties need to be managed outside Transifex. The main drawback on the configuration side of transifex is to have to >> configure all the different property files we want to translate and then >> upload the translations we want to retrieve from Transifex. >> > > Ouch yes, that's annoying. > Once again, it's only for initializing the workflow : we can also directly link existing Transifex project to GitHub resource but I don't know what will happen to the existing Transifex translations in case of conflict. > > One question about the PRs that GeoServer will receive... how do we manage > them? > Since they are automated, can we just trust them and merge them if the > builds are green? > Is there any control on the level of translation (like, don't make PRs > unless translation > is at least at a given percentage)? > By default, Transifex automatically creates PR only when the resource for a language is 100% translated. This can be changed to add the additional requirement of being 100% reviewed. The only way to create PR with partially translated content is a manual sync by one of the maintainers of the project. > What about protection from vandalism? I know contributors mean well, but > we could have > situations where a new contributor is going for a prank against the > community, or credential > access is gained by external parties, which then use Transifex to add > unsavoury content > to the translation (e.g., links to their own web sites for example). > The only mechanism I see is a review by a member of the review team but you still have the risk that a reviewer or a maintainer got its credentials stolen. Regards Alexandre > Cheers > Andrea > > == > > GeoServer Professional Services from the experts! > > Visit http://bit.ly/gs-services-us for more information. > == > > Ing. Andrea Aime > @geowolf > Technical Lead > > GeoSolutions Group > phone: +39 0584 962313 > > fax: +39 0584 1660272 > > mob: +39 333 8128928 > > https://www.geosolutionsgroup.com/ > > http://twitter.com/geosolutions_it > > ------------------------------------------------------- > > Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE > 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si > precisa che ogni circostanza inerente alla presente email (il suo > contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è > riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il > messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra > operazione è illecita. Le sarei comunque grato se potesse darmene notizia. > > This email is intended only for the person or entity to which it is > addressed and may contain information that is privileged, confidential or > otherwise protected from disclosure. We remind that - as provided by > European Regulation 2016/679 “GDPR” - copying, dissemination or use of this > e-mail or the information herein by anyone other than the intended > recipient is prohibited. If you have received this email by mistake, please > notify us immediately by telephone or e-mail > -- Alexandre Gacon
_______________________________________________ Geoserver-users mailing list Please make sure you read the following two resources before posting to this list: - Earning your support instead of buying it, but Ian Turton: http://www.ianturton.com/talks/foss4g.html#/ - The GeoServer user list posting guidelines: http://geoserver.org/comm/userlist-guidelines.html If you want to request a feature or an improvement, also see this: https://github.com/geoserver/geoserver/wiki/Successfully-requesting-and-integrating-new-features-and-improvements-in-GeoServer Geoserver-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-users
