Just commited some changes which are mainly javadoc and code reformating
(adding
the missing copyright headers, adding missing @since javadoc tag), editing some
comments, replaced tabulations by spaces in code). The only significant changes
in the code itself was:
1) NullObjectCache, DefaultObjectCache and ObjectCacheEntry
visibility changed from 'public' to 'package-privated'.
I believe it is safer since I'm not sure that
ObjectCacheEntry should exist for example.
2) Synchronized statements in DefaultObjectCache performed
explicitly on the 'cache' Map rather than relying on the
Collections.synchronizedMap(Map) method, because the later
uses an other lock that the one expected by some methods
of DefaultObjectCache.
3) NullObjectCache constructor is made private, and a
singleton instance is used instead.
4) Minor tuning in usage of Java Collections (e.g. replaced
"if (map.containsKey(key)) foo=map.get(key)" by
"foo=map.get(key); if (foo!=null) ...", which perform
only when search in the map instead of two.
As of stability, I believe that Jody rolled back most of the changes in the old
system. But the new system is mixed among the classes of the old ones, which
may
be a little bit confusing if we release them in 2.4... (a partial report to 2.5
would allow cleaner separation...)
Given that I do not expect major changes in referencing module for Geotools
2.5,
it may not be too hard to port the work done on 2.5 toward the 2.4 branch for a
2.4.1 release, except maybe for the Java 5 features...
Martin
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
