Martin Desruisseaux ha scritto: > Andrea Aime a écrit : >> Hmm.... the redirect method for the old commons logging redirection >> was in Logging as well as other logging utility methods. >> Anyways, I'm ok about putting the stuff in GeoTools as well... >> Martin? > > For CommonHandler, we did a mix: > > - Logging class contains method with a clear role (one method = one task). > Example: redirectToCommonLogging(). > > - GeoTools contains a init() method which invokes a bunch of methods > believed to be wanted in many usage. For example init() invokes > redirectToCommonLogging() and some other methods I forget. So it is > a black box that break the "one method = one task" rule. > > I suggests to do the same that what we did in CommonHandler: > > - Put redirectToLog4J in Logging. > - Invoke redirectToLog4J from GeoTools.init(), together with other > typical convenience methods.
That GeoTools.setFactory(LogFactory factory) proposal from Jody sounds nice in that it's extensible... I really don't understand why GeoTooos.init() should call redirectToCommonLogging() thought? Cheers Andrea ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
