Andrea Aime wrote: > Hi, > > today I was looking into a postgis issue and found > that many tests on trunk were broken. > Investigating I tracked down the issue at a commit Jody > made one month and a half ago, that enables the length > restriction parsing on attributes: > r31660, October 14 2008, "Make use of length if available" > I believe I was applying a patch. > Which is nice, but breaks most equality tests used to check the feature types > are properly parsed in our tests. > In what way does this break the equality tests? Is data being truncated? > Now, I'm wondering two things: > - why is the build box not running the postgis tests? > We must re-enable this, the normal dev build does not run them > That is also my question. > - Jody, did you run the tests before committing? > Apparently not. > Fixing this requires a softer equality, one that does not care about the > restrictions, and that > needs to be propagated in quite a bit of places... > It sounds like you are asking for a comparison of FeatureType here? Equality test for FeatureType? Perhaps what is needed is DataUtilities.compare( FeatureType, FeatureType ). > quite a bit of work! > For the short term I think the solution would be to revert your changes > and open a jira issue to fix it properly? > This is a dammed if you do dammed if you don't - the length information is needed if we are going to export from PostGIS into a shapefile correctly.
Jody ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
