Jody Garnett ha scritto: > Andrea Aime wrote: ... > Apparently not. >> Fixing this requires a softer equality, one that does not care about >> the restrictions, and that >> needs to be propagated in quite a bit of places... >> > It sounds like you are asking for a comparison of FeatureType here? > Equality test for FeatureType? Perhaps what is needed is > DataUtilities.compare( FeatureType, FeatureType ).
Hmmm.... running the tests once and see what happens is too much to ask? Anyways, what happens is that in the old equals methods (2.4.x timeframe) the restrictions were not used as part of the equality comparison, in the new (2.5.x+) they are. When a test tries to compare attribute by attribute the schemas to the ones we have declared in TestData (remember, big class with all the sample feature types and sample features used for tests?) it finds the restrictions are not the same and boom, test start failing like a domino and eventually the whole suite hangs compeletely (unclosed readers exausting the server max connection count I believe, but I did not check). >> quite a bit of work! >> For the short term I think the solution would be to revert your >> changes and open a jira issue to fix it properly? >> > This is a dammed if you do dammed if you don't - the length information > is needed if we are going to export from PostGIS into a shapefile > correctly. Well, broken build is in my book more damned, it prevents any other work in the module. It's the first single thing a developer should never break, and it's usually part of the dev responsibility to fix the build he broke as well. So if you don't, I'm going to revert the change and open a jira about it (let's call it a blocker if you want) to fix things on trunk. Cheers Andrea -- Andrea Aime OpenGeo - http://opengeo.org Expert service straight from the developers. ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
