Jody Garnett ha scritto: > I feel a bit like the shot messenger; the change to the new feature > model resulted in the change to the equals contract. During that change > we lost the length information that I depended on for exporting > shapefiles from a PostGIS table FeatureType. Restoring that has shown > that the FeatureType equals contract has broken a bunch of tests...
Restoring that? I looked into the 2.4.x JDBC1DataStore, there is no length information added to the fields there? Here: http://gtsvn.refractions.net/branches/2.4.x/modules/library/jdbc/src/main/java/org/geotools/data/jdbc/JDBC1DataStore.java Looked into PostgisDataStore as well, no length information there either. And I cannot find anything in 2.2.x either: http://gtsvn.refractions.net/branches/2.2.x/module/main/src/org/geotools/data/jdbc/JDBC1DataStore.java So... how is this a functionality restore? > ... so we have some more feature model change over work to do right? It seems so, yeah. The cleanest solution would be to fix the tests, as including all the informations you have (restrictions included) in the equality comparison seems a sensible decision. > Andrea I am going to try and stay late and hack (since I have no > Internet at home) - is this what you would like me to work on? If you can bring new functionality without breaking the online tests I'm all for it. But I'm not trying to force you into doing anything, just asking that you run the online unit test before committing changes and make sure they still work fine. Which is not really me asking, it's the developer guide as far as I remember. Cheers Andrea -- Andrea Aime OpenGeo - http://opengeo.org Expert service straight from the developers. ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
