Jody Garnett ha scritto: > Andrea Aime wrote: >> Looked into PostgisDataStore as well, no length information there >> either. And I cannot find anything in 2.2.x either: >> http://gtsvn.refractions.net/branches/2.2.x/module/main/src/org/geotools/data/jdbc/JDBC1DataStore.java >> >> >> >> So... how is this a functionality restore? > Perhaps I am confused; I string length to be handled by all the > datastores - was it simply not being reported previously?
As far as I can see it has never been added into the jdbc datastore generated attributes before your patch. Look at the old code and tell where where the length information is added... I can't see it. >>> ... so we have some more feature model change over work to do >>> right? >> It seems so, yeah. The cleanest solution would be to fix the tests, >> as including all the informations you have (restrictions included) >> in the equality comparison seems a sensible decision. > Question: Is there anyway I can ask Hudson to run the tests for me? No, as I told you in a previous mail in this thread, this would be source of many issues. Why can't you just install PostGIS on your computer, it does not uses much resources and you can start it on demand if you want? >>> Andrea I am going to try and stay late and hack (since I have no >>> Internet at home) - is this what you would like me to work on? >> If you can bring new functionality without breaking the online >> tests I'm all for it. But I'm not trying to force you into doing >> anything, just asking that you run the online unit test before >> committing changes and make sure they still work fine. Which is not >> really me asking, it's the developer guide as far as I remember. > Understood; it is just tricky to ensure I have a postgis to test > against - as you mentioned that is the root of this problem. Jody Postgis is probably the easiest to install database around... if you're on windows, you have the installer, if you're on linux, you just apt-get the proper packages... Cheers Andrea -- Andrea Aime OpenGeo - http://opengeo.org Expert service straight from the developers. ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
