On Sun, Apr 17, 2011 at 4:57 AM, Jody Garnett <[email protected]> wrote: > Proposal up: > - http://docs.codehaus.org/display/GEOTOOLS/Function+Description+with+FilterFactory+cleanup
Now, moving on the merits of the proposal... I like the idea of being able to provide names to the arguments, makes keeping up docs much easier and allows to build GUIs that describe what functions are about (a bit at least). Having Function return its FunctionName... makes sense, thought the name seems misleading... isn't that more of a FunctionDescription? I understand the API is already like that, just trying to get why it's called a Name. In any case, I agree the function should be able to describe itself. The factory changes leave me with a "huh?" moment: FunctionName functionName(String name, int nargs, List<String> argNames); So this means we now have function overloading, but not the java way, based on attribute types, but on the argument names instead? That sounds odd to me, wouldn't it be better to leave overloading aside and just demand a unique name? Also, what about functions that take a varying number of arguments? Most process wrapping functions do, but for the sake of simpler discussion, what about the case of a "in" function, in(propertyName, val1, val2, ..., valn), how would it work respect to nargs and argnames? Cheers Andrea -- ------------------------------------------------------- Ing. Andrea Aime GeoSolutions S.A.S. Tech lead Via Poggio alle Viti 1187 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 962313 mob: +39 333 8128928 http://www.geo-solutions.it http://geo-solutions.blogspot.com/ http://www.youtube.com/user/GeoSolutionsIT http://www.linkedin.com/in/andreaaime http://twitter.com/geowolf ------------------------------------------------------- ------------------------------------------------------------------------------ Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
