Okay I think I understand; but we would have that same confusion just with the 
existing method right?

How about we change the parameter name to be "unqiueFunctionName".

I tend to like what I suggested; however here are a couple of alternate ideas:

1. Avoid the possibility of confusion (well we could not do negative number of 
args this way):

FilterFactory.functionName( String unqiueFunctionName, int nargs);
FilterFactory.functionName( String unqiueFunctionName, List<String> arguments )

2. break my head

FilterFactory.functionName( String unqiueFunctionName, int nargs, Hints hints )


No matter what we do people could make conflicting FunctionNames; they may even 
need to if they are working with
multiple external servers.

-- 
Jody Garnett

On Sunday, 17 April 2011 at 11:24 PM, Andrea Aime wrote: 
> On Sun, Apr 17, 2011 at 1:18 PM, Jody Garnett <[email protected]> wrote:
> 
> > I don't understand? We have an internal FunctionNameImpl; but the factory
> > only allows me to call functionName( String name, int args). There is no way
> > using the factory to make a FunctionName that includes the list of
> > attributes.
> 
> From your proposal:
> 
> interface FilterFactory {
>  ....
>  /** function name */
>  FunctionName functionName(String name, int nargs);
>  FunctionName functionName(String name, int nargs, List<String> argNames);
>  ...
> }
> 
> Now looking at the interface without thinking about how it's
> implemented I would gather
> that:
> - it's possible to have multiple functions named the same way,
> provided they have
>  a different amount of arguments
> - it's possible to have mutiple functions named in the same way, with the same
>  amount of arguments, provided they have different argument names.
> 
> Makes sense?
> 
> Cheers
> Andrea
> 
> -- 
> -------------------------------------------------------
> Ing. Andrea Aime
> GeoSolutions S.A.S.
> Tech lead
> 
> Via Poggio alle Viti 1187
> 55054 Massarosa (LU)
> Italy
> 
> phone: +39 0584 962313
> fax: +39 0584 962313
> mob: +39 333 8128928
> 
> http://www.geo-solutions.it
> http://geo-solutions.blogspot.com/
> http://www.youtube.com/user/GeoSolutionsIT
> http://www.linkedin.com/in/andreaaime
> http://twitter.com/geowolf
> 
> -------------------------------------------------------
> 
------------------------------------------------------------------------------
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to