On 13/02/17 06:22, Andrea Aime wrote: >> Did we already investigate other options that allow us to do style checks >> (and other checks) only for a specific pull request (branch) changes ? >> In a quick search on Google I stepped on this: >> https://github.com/mmozuras/pronto > No, we never did. The pronto project seems to be ruby specific, from what I > see. > Did you find anything that would work with Java and/or Maven? I could not
We have accepted several pull requests that fixed linting issues detected with SonarLint. I see that SonarQube supports Maven integration. I have used neither. See: https://docs.travis-ci.com/user/sonarqube/ The sonarqube.com service appears to be free for open source projects (perhaps the same business model as GitHub and Travis CI?): https://sonarqube.com/about If we do adopt automatic code style checking, we could get even more benefit by using a code quality tool. The remaining issue is how strictly we enforce the rules and at what point. If we can do it on Travis CI, then I think it will be workable. The problem is that we still have cherry-picks and direct pushes that will circumvent Travis CI and might lead to false blaming of later pull requests (no different to unit test failures, which have the same problem). Kind regards, -- Ben Caradoc-Davies <b...@transient.nz> Director Transient Software Limited <http://transient.nz/> New Zealand ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
