Hi Jody,
so I see you commented out all deprecated methods in FactoryRegistry.
Good, it proves no calling point remain, and more importantly, thanks
Nicolai for updating
all call points to use the newer API.
Now... commented out code is a no-go. Jody, do you really want to push for
a hard-break
without warning?
Once the GeoTools/GeoServer/GWC are fine, I'd uncomment them and give users
at least one round of warning.
Cheers
Andrea
On Fri, Nov 10, 2017 at 7:53 AM, Andrea Aime <[email protected]>
wrote:
> Hi Jody,
> did not check yet, but were all newly deprecated method calls removed from
> the codebase
> and replaced with non deprecated equivalents?
>
> Cheers
> Andrea
>
>
> On Fri, Nov 10, 2017 at 1:38 AM, Jody Garnett <[email protected]>
> wrote:
>
>> Okay we are good to go:
>>
>> - GeoTools: https://github.com/geotools/geotools/pull/1670
>> - GWC: no change
>> - GeoServer: https://github.com/geoserver/geoserver/pull/2628
>>
>> --
>> Jody Garnett
>>
>> On 9 November 2017 at 12:31, Jody Garnett <[email protected]> wrote:
>>
>>> I think I have addressed the remaining feedback on the pull request.
>>>
>>> Andrea if I understand your feedback is addressed, but we need some
>>> "trivial changes" in GWC and GeoServer mentioned above - do you have those
>>> changes on a branch?
>>>
>>> --
>>> Jody Garnett
>>>
>>> On 8 November 2017 at 08:02, Jody Garnett <[email protected]>
>>> wrote:
>>>
>>>> Thanks, considering the proposal passed :)
>>>>
>>>> I will volunteer to make a milestone release, since Java 9 is already
>>>> available.
>>>>
>>>> --
>>>> Jody Garnett
>>>>
>>>> On 7 November 2017 at 16:15, Jody Garnett <[email protected]>
>>>> wrote:
>>>>
>>>>> So after a month we have:
>>>>>
>>>>> - Andrea Aime +1
>>>>> - Ben Caradoc-Davies +1
>>>>> - Christian Mueller
>>>>> - Ian Turton +1
>>>>> - Justin Deoliveira
>>>>> - Jody Garnett +1
>>>>> - Simone Giannecchini
>>>>>
>>>>> We have no -1 votes, thanks for the review Andrea. Justin, Christian,
>>>>> Simone do you have any feedback or can we consider this motion passed?
>>>>>
>>>>>
>>>>> --
>>>>> Jody Garnett
>>>>>
>>>>> On 3 October 2017 at 14:31, Jody Garnett <[email protected]>
>>>>> wrote:
>>>>>
>>>>>> As a follow up to today's meeting, please consider and vote on the
>>>>>> following proposal:
>>>>>>
>>>>>> https://github.com/geotools/geotools/wiki/FactoryRegistry-Re
>>>>>> factoring-for-Java-9-Compatibility
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Jody Garnett
>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>
>> ------------------------------------------------------------
>> ------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> _______________________________________________
>> GeoTools-Devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>>
>>
>
>
> --
>
> Regards,
>
> Andrea Aime
>
> ==
> GeoServer Professional Services from the experts! Visit
> http://goo.gl/it488V for more information.
> ==
>
> Ing. Andrea Aime
> @geowolf
> Technical Lead
>
> GeoSolutions S.A.S.
> Via di Montramito 3/A
> 55054 Massarosa (LU)
> phone: +39 0584 962313 <+39%200584%20962313>
> fax: +39 0584 1660272 <+39%200584%20166%200272>
> mob: +39 339 8844549 <+39%20339%20884%204549>
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
>
> Le informazioni contenute in questo messaggio di posta elettronica e/o
> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
> loro utilizzo è consentito esclusivamente al destinatario del messaggio,
> per le finalità indicate nel messaggio stesso. Qualora riceviate questo
> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
> darcene notizia via e-mail e di procedere alla distruzione del messaggio
> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
> utilizzarlo per finalità diverse, costituisce comportamento contrario ai
> principi dettati dal D.Lgs. 196/2003.
>
> The information in this message and/or attachments, is intended solely for
> the attention and use of the named addressee(s) and may be confidential or
> proprietary in nature or covered by the provisions of privacy act
> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
> Code).Any use not in accord with its purpose, any disclosure, reproduction,
> copying, distribution, or either dissemination, either whole or partial, is
> strictly forbidden except previous formal approval of the named
> addressee(s). If you are not the intended recipient, please contact
> immediately the sender by telephone, fax or e-mail and delete the
> information in this message that has been received in error. The sender
> does not give any warranty or accept liability as the content, accuracy or
> completeness of sent messages and accepts no responsibility for changes
> made after they were sent or for other risks which arise as a result of
> e-mail transmission, viruses, etc.
>
>
--
Regards,
Andrea Aime
==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
