Patch Set 2: (1 comment)
The main issue is that it's a chicken-egg problem. I cannot properly identify a modem until I use it, because we are identifying them using the IMSI and to check which is the one I need to potentially power on all of them. So, I guess to solve that, we would need at startup to dynamically populate the shared "resources" config adding the discovered path to each modem resource. Then, when we want to discover the path from IMSI, we first look there in the resources pool. If we cannot get a path from the IMSI, we iterate over ofono GetModems() and we only query the ones whose path is not in the "shared resource poll". https://gerrit.osmocom.org/#/c/2676/2/src/osmo_gsm_tester/ofono_client.py File src/osmo_gsm_tester/ofono_client.py: Line 70: def _wait(condition, condition_args, condition_kwargs, timeout, timestep): > I'm confused, didn't I write this code? are you moving it around, but I don I'm duplicating it to avoid the problem to call through test.wait() (->suite.wait()). It's not exactly the same because this one calls poll() on the same file instead of calling suite.poll() which does more stuff like checking for termination of subprocesses. We don't need that here and those will nevertherless be checked later on when we provide control to the test at some point, and no issue if we don't check that here because we don't interact with those processes from this module. -- To view, visit https://gerrit.osmocom.org/2676 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9f4de81abc18e8db0c15df965e4811b6513e1b1 Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: Yes
