Patch Set 2: (1 comment)
https://gerrit.osmocom.org/#/c/2676/2/src/osmo_gsm_tester/ofono_client.py File src/osmo_gsm_tester/ofono_client.py: Line 70: def _wait(condition, condition_args, condition_kwargs, timeout, timestep): > I'm duplicating it to avoid the problem to call through test.wait() (->suit what is the problem you're solving? That test.wait is not populated in the beginning? I do not want to duplicate this code. Let's have one central poll() that does all polling. If there are no processes that need polling, then that list is empty and we don't poll any. If there are, *any* busy loop should poll them, also this one. So let's fix my bad structuring by moving the poll guts up one level out of suite.py. Have a central poll / wait mechanism and let test.wait and suite.poll and so on call that, instead of everything else call suite.poll. (we may need to discuss the details) My intention was that nothing really needs wait() or poll() except test scripts, but the DBus interaction thwarts that plan. -- To view, visit https://gerrit.osmocom.org/2676 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9f4de81abc18e8db0c15df965e4811b6513e1b1 Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-HasComments: Yes
