Patch Set 2: (1 comment)
https://gerrit.osmocom.org/#/c/2676/2/src/osmo_gsm_tester/ofono_client.py File src/osmo_gsm_tester/ofono_client.py: Line 70: def _wait(condition, condition_args, condition_kwargs, timeout, timestep): > what is the problem you're solving? That test.wait is not populated in the The problem we are solving is basically the issue you pointed out in some patch as "we should avoid calling suite_run.wait() or test.wait(), feel free to improve that". I agree, we can move this wait() to a top level and use it in all required placed to have a unique loop. I'll do this when I push next version of this patch + an extra patch for https://osmocom.org/issues/2243 -- To view, visit https://gerrit.osmocom.org/2676 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9f4de81abc18e8db0c15df965e4811b6513e1b1 Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: Yes
