Patch Set 1: I agree in the sense that the implementation is a bit more complex than what we initially though, but now that it's already there and it works I think it's nice to keep it as it simplifies configuration and still provides the possibility to configure it manually as done before.
Alternatively, I'm thinking whether it would also make sense to use the modem path in the config and skip adding the IMSI there but just get it from SimManager. -- To view, visit https://gerrit.osmocom.org/2696 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I602604d25f51b24d87877bc8ac798525b7be61dd Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: No
