keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/24236 )
Change subject: Add support for LCLS to the MSC ...................................................................... Patch Set 6: (1 comment) This change is ready for review. https://gerrit.osmocom.org/c/osmo-msc/+/24236/6/include/osmocom/msc/transaction.h File include/osmocom/msc/transaction.h: https://gerrit.osmocom.org/c/osmo-msc/+/24236/6/include/osmocom/msc/transaction.h@103 PS6, Line 103: struct osmo_lcls *lcls; I had some conversation with @neels before about not having this here as a pointer, which requires quite a lot of changes; - I think then trans_lcls_compose() would modify the member directly and return a status int ? I have a branch where I was working on it that way, but I never got it quite right. I don't know how important it would be to do this. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/24236 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I705c860e51637b4537cad65a330ecbaaca96dd5b Gerrit-Change-Number: 24236 Gerrit-PatchSet: 6 Gerrit-Owner: keith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Tue, 05 Oct 2021 20:04:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
