keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/24236 )
Change subject: Add support for LCLS to the MSC ...................................................................... Patch Set 7: (1 comment) > Patch Set 7: Code-Review+1 > > (3 comments) > > it would be nice to have the MNCC protocol version change in a separate > patch, so that it is easy to read what parts relate to the bare protocol > change, and what parts relate to functional change in osmo-msc The protocol change is 3 lines in mncc.h (in fact the commit would just be mncc.h from this patchset and nothing else. I can do it, but does it really make a difference? https://gerrit.osmocom.org/c/osmo-msc/+/24236/7/include/osmocom/msc/mncc.h File include/osmocom/msc/mncc.h: https://gerrit.osmocom.org/c/osmo-msc/+/24236/7/include/osmocom/msc/mncc.h@164 PS7, Line 164: struct osmo_gcr_parsed gcr; > this is a good place, besides the SDP always being in the end, this leaves > previous version MNCC unc […] Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/24236 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I705c860e51637b4537cad65a330ecbaaca96dd5b Gerrit-Change-Number: 24236 Gerrit-PatchSet: 7 Gerrit-Owner: keith <[email protected]> Gerrit-Assignee: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Mon, 18 Oct 2021 20:05:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <[email protected]> Comment-In-Reply-To: dexter <[email protected]> Gerrit-MessageType: comment
