neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/24236 )
Change subject: Add support for LCLS to the MSC ...................................................................... Patch Set 7: Code-Review+1 (3 comments) it would be nice to have the MNCC protocol version change in a separate patch, so that it is easy to read what parts relate to the bare protocol change, and what parts relate to functional change in osmo-msc https://gerrit.osmocom.org/c/osmo-msc/+/24236/7/include/osmocom/msc/gsm_data.h File include/osmocom/msc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-msc/+/24236/7/include/osmocom/msc/gsm_data.h@264 PS7, Line 264: bool lcls_disable; > A long long time ago, in a land far far away, > (https://gerrit.osmocom.org/c/osmo-msc/+/13421) […] i generally dislike reverse logic booleans, the double negation can make reading logic a nightmare... disabled = (foo() != 0); it's better to choose the boolean name as an affirmative, so that "true" does not mean "off". so here i'd indeed go for "lcls_permitted" https://gerrit.osmocom.org/c/osmo-msc/+/24236/7/include/osmocom/msc/mncc.h File include/osmocom/msc/mncc.h: https://gerrit.osmocom.org/c/osmo-msc/+/24236/7/include/osmocom/msc/mncc.h@164 PS7, Line 164: struct osmo_gcr_parsed gcr; > There is probably a better place for this. […] this is a good place, besides the SDP always being in the end, this leaves previous version MNCC unchanged. https://gerrit.osmocom.org/c/osmo-msc/+/24236/7/src/libmsc/msc_vty.c File src/libmsc/msc_vty.c: https://gerrit.osmocom.org/c/osmo-msc/+/24236/7/src/libmsc/msc_vty.c@511 PS7, Line 511: "no lcls-disable", also here i would much perfer 'lcls-permitted' to avoid double negation -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/24236 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I705c860e51637b4537cad65a330ecbaaca96dd5b Gerrit-Change-Number: 24236 Gerrit-PatchSet: 7 Gerrit-Owner: keith <[email protected]> Gerrit-Assignee: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Mon, 18 Oct 2021 11:45:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: keith <[email protected]> Comment-In-Reply-To: dexter <[email protected]> Gerrit-MessageType: comment
