keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/24236 )
Change subject: Add support for LCLS to the MSC ...................................................................... Patch Set 9: (2 comments) https://gerrit.osmocom.org/c/osmo-msc/+/24236/7/include/osmocom/msc/gsm_data.h File include/osmocom/msc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-msc/+/24236/7/include/osmocom/msc/gsm_data.h@264 PS7, Line 264: bool lcls_disable; > i generally dislike reverse logic booleans, the double negation can make > reading logic a nightmare.. […] Done https://gerrit.osmocom.org/c/osmo-msc/+/24236/9/include/osmocom/msc/transaction.h File include/osmocom/msc/transaction.h: https://gerrit.osmocom.org/c/osmo-msc/+/24236/9/include/osmocom/msc/transaction.h@103 PS9, Line 103: struct osmo_lcls *lcls; I had some conversation with @neels before about not having this here as a pointer, which requires quite a lot of changes; - I think then trans_lcls_compose() would modify the member directly and return a status int ? I have a branch where I was working on it that way, but I never got it quite right. I don't know how important it would be to do this. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/24236 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I705c860e51637b4537cad65a330ecbaaca96dd5b Gerrit-Change-Number: 24236 Gerrit-PatchSet: 9 Gerrit-Owner: keith <[email protected]> Gerrit-Assignee: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Mon, 18 Oct 2021 20:29:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <[email protected]> Comment-In-Reply-To: keith <[email protected]> Comment-In-Reply-To: dexter <[email protected]> Gerrit-MessageType: comment
