Attention is currently required from: pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30210 )
Change subject: osmux: Introduce API osmux_xfrm_input_set_name() ...................................................................... Patch Set 2: (2 comments) File src/osmux_input.c: https://gerrit.osmocom.org/c/libosmo-netif/+/30210/comment/4735816d_38cd765d PS2, Line 732: link->name = talloc_asprintf(link, "%p", h); > To identify the different links by default without the user having to add a > name (hence being able t […] That seems backwards to me. If old users want to identify links they could simply switch to using new API. And if they don't than it's pointless to carry workarounds to cater to that use-case. File tests/testsuite.at: https://gerrit.osmocom.org/c/libosmo-netif/+/30210/comment/6e1f9050_fec02f63 PS2, Line 14: # Following sed gets rid of pointer addresses to have reproducible output: > Yeah, backward compatibility is though ;) This is not the case though - backward compatibility is when we keep old behavior for old API while adding new API. If we change behavior of old API to try to emulate the use of new API to the point that we have to rely on workarounds to keep unit tests from failing - it only adds unnecessary confusion. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30210 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ibbcfdb23a6015ce45840bb64b2b560c2806f7ff6 Gerrit-Change-Number: 30210 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Fri, 18 Nov 2022 15:34:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: msuraev <[email protected]> Gerrit-MessageType: comment
