Attention is currently required from: pespin.
osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/30210 )

Change subject: osmux: Introduce API osmux_xfrm_input_set_name()
......................................................................


Patch Set 2:

(1 comment)

File src/osmux_input.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/30210/comment/232d0e96_d17fe216
PS2, Line 732:  link->name = talloc_asprintf(link, "%p", h);
> To identify the different links by default without the user having to add a 
> name (hence being able t […]
how about using a simple counter instead of using pointers? then we wouldn't 
need the sed replacement



--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30210
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ibbcfdb23a6015ce45840bb64b2b560c2806f7ff6
Gerrit-Change-Number: 30210
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: msuraev <[email protected]>
Gerrit-CC: osmith <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Fri, 18 Nov 2022 15:36:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Comment-In-Reply-To: msuraev <[email protected]>
Gerrit-MessageType: comment

Reply via email to