Attention is currently required from: osmith, pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30210 )
Change subject: osmux: Introduce API osmux_xfrm_input_set_name() ...................................................................... Patch Set 3: Code-Review+1 (3 comments) File src/osmux_input.c: https://gerrit.osmocom.org/c/libosmo-netif/+/30210/comment/cde3c373_bb47f764 PS2, Line 732: link->name = talloc_asprintf(link, "%p", h); > If there's some deployed software which is hard to update and modify than the > issues which makes upd […] Done https://gerrit.osmocom.org/c/libosmo-netif/+/30210/comment/50bfc7ff_8e78031e PS2, Line 777: osmo_talloc_replace_string(link, &link->name, name); > See my other comment in my answer. Done File tests/testsuite.at: https://gerrit.osmocom.org/c/libosmo-netif/+/30210/comment/6ec47527_88b8ee4c PS2, Line 14: # Following sed gets rid of pointer addresses to have reproducible output: > This is not the case though - backward compatibility is when we keep old > behavior for old API while […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30210 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ibbcfdb23a6015ce45840bb64b2b560c2806f7ff6 Gerrit-Change-Number: 30210 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: msuraev <[email protected]> Gerrit-CC: osmith <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Sun, 20 Nov 2022 12:20:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: msuraev <[email protected]> Gerrit-MessageType: comment
