Attention is currently required from: osmith, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30210 )
Change subject: osmux: Introduce API osmux_xfrm_input_set_name() ...................................................................... Patch Set 2: (1 comment) File src/osmux_input.c: https://gerrit.osmocom.org/c/libosmo-netif/+/30210/comment/1157848b_ba86996f PS2, Line 732: link->name = talloc_asprintf(link, "%p", h); > how about using a simple counter instead of using pointers? then we wouldn't > need the sed replacemen […] Max: You are mixing stuff here. One thing is the deployed software which may be difficult to upgrade/modify, and the other is the libosmo-netif implementation in use. Since this seems to be causing rejection for this patch I can then simply totally drop the pointer and allocate an empty string, or do as osmith suggests, though I don't find it as useful for debuggin purposes as having an address pointer. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30210 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ibbcfdb23a6015ce45840bb64b2b560c2806f7ff6 Gerrit-Change-Number: 30210 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <[email protected]> Gerrit-CC: osmith <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Attention: msuraev <[email protected]> Gerrit-Comment-Date: Fri, 18 Nov 2022 15:45:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: msuraev <[email protected]> Gerrit-MessageType: comment
