Attention is currently required from: jolly.

pespin has posted comments on this change by jolly. ( 
https://gerrit.osmocom.org/c/libosmocore/+/40491?usp=email )

Change subject: Add multiple messages buffers to struct iofd_msghdr
......................................................................


Patch Set 3:

(1 comment)

File src/core/osmo_io_uring.c:

https://gerrit.osmocom.org/c/libosmocore/+/40491/comment/c32b5dec_2317b491?usp=email
 :
PS3, Line 110:          g_io_uring_iov = atoi(env);
afaict this is not some information which is needed really early in the startup 
of the program, before logging, etc. (the reason why we have an envvar to set 
the osmo_io backend), hence I think this new config shouldn't be an envvar, but 
rather some config to set using an API on a given osmo_iofd or similar, which 
then the app developer can tweak based on socket requirements.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40491?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I4fb1067de4615cc22cc6caf99b481491e7f2ef92
Gerrit-Change-Number: 40491
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: jolly <[email protected]>
Gerrit-Comment-Date: Fri, 04 Jul 2025 13:49:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to