Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40491?usp=email )
Change subject: Add multiple messages buffers to struct iofd_msghdr ...................................................................... Patch Set 3: Code-Review-1 (4 comments) Patchset: PS3: I'm not sure I'm understanding this commit. You are adding arrays but only using the first one despite configuring the global variable to something != 1? This shouldn't be submitted like this alone imho. File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/40491/comment/f5d41077_e8478105?usp=email : PS3, Line 165: hdr->msg_max = (g_io_backend == OSMO_IO_BACKEND_IO_URING) ? g_io_uring_iov : 1; this info should be obtained from osmo_io_fd struct. https://gerrit.osmocom.org/c/libosmocore/+/40491/comment/b77abd4b_03d9c085?usp=email : PS3, Line 406: struct msgb *msg = msghdr->msg[0]; why is this and below always [0]? File src/core/osmo_io_internal.h: https://gerrit.osmocom.org/c/libosmocore/+/40491/comment/b2a486b1_a188b6b3?usp=email : PS3, Line 140: int msg_max; this field should probably be in struct osmo_iofd. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40491?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4fb1067de4615cc22cc6caf99b481491e7f2ef92 Gerrit-Change-Number: 40491 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andr...@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Attention: jolly <andr...@eversberg.eu> Gerrit-Comment-Date: Fri, 04 Jul 2025 13:54:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
