Attention is currently required from: jolly, laforge. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40491?usp=email )
Change subject: Add multiple messages buffers to struct iofd_msghdr ...................................................................... Patch Set 6: (4 comments) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/40491/comment/8fdce964_6ad3d2c2?usp=email : PS6, Line 747: * If your osmo_io_fd is in OSMO_IO_FD_MODE_READ_WRITE mode, this API function can be used to tell the Please add proper doxygen documentation of params here. https://gerrit.osmocom.org/c/libosmocore/+/40491/comment/155cebec_e6facfe4?usp=email : PS6, Line 748: * osmo_io code how many buffers should be read or written with a single read or write operation. "read or write". Extra space. https://gerrit.osmocom.org/c/libosmocore/+/40491/comment/97467d14_19cb241b?usp=email : PS6, Line 751: int osmo_iofd_set_io_buffers(struct osmo_io_fd *iofd, int buffers) unsigned int buffers? Only reason to use an "int" here would be to allow some sort of -1=default, which I don't see documented. File src/core/osmo_io_internal.h: https://gerrit.osmocom.org/c/libosmocore/+/40491/comment/03e7a402_06382545?usp=email : PS6, Line 143: int io_len; this can also be a unsigned int. And even actually a uint8_t. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40491?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4fb1067de4615cc22cc6caf99b481491e7f2ef92 Gerrit-Change-Number: 40491 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andr...@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Attention: jolly <andr...@eversberg.eu> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Wed, 23 Jul 2025 14:04:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
