Attention is currently required from: laforge, pespin.

jolly has posted comments on this change by jolly. ( 
https://gerrit.osmocom.org/c/libosmocore/+/40491?usp=email )

Change subject: Add multiple messages buffers to struct iofd_msghdr
......................................................................


Patch Set 6:

(2 comments)

File src/core/osmo_io_internal.h:

https://gerrit.osmocom.org/c/libosmocore/+/40491/comment/7e36cd82_3a36aa3c?usp=email
 :
PS5, Line 143:  int io_len;
> I wonder whether this is needed or can be inferred when needed by looking up 
> NULL ptrs in "msg" fiel […]
Without it, we would have extra loops. I want to avoid that. Alternatively we 
could use a list of msgb+iovec in an extra structure. This would make it much 
more complex.


File src/core/osmo_io_internal.h:

https://gerrit.osmocom.org/c/libosmocore/+/40491/comment/5b827776_3017afd8?usp=email
 :
PS3, Line 140:  int msg_max;
> This should definetly be configurable over API per osmo_iofd object. […]
Done



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40491?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I4fb1067de4615cc22cc6caf99b481491e7f2ef92
Gerrit-Change-Number: 40491
Gerrit-PatchSet: 6
Gerrit-Owner: jolly <andr...@eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-CC: laforge <lafo...@osmocom.org>
Gerrit-Attention: laforge <lafo...@osmocom.org>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Wed, 23 Jul 2025 10:46:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly <andr...@eversberg.eu>
Comment-In-Reply-To: laforge <lafo...@osmocom.org>
Comment-In-Reply-To: pespin <pes...@sysmocom.de>

Reply via email to