Attention is currently required from: falconia, pespin.

jolly has posted comments on this change by falconia. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email )

Change subject: bring twjit into libosmo-netif
......................................................................


Patch Set 5:

(1 comment)

File src/twjit.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/489ebdbb_3dbbe7b7?usp=email
 :
PS5, Line 486:                  msgb_free(new_msg);
Is there a twjit instance for every payload type or one for the complete RTP 
connection?

telephone-event payload may (and will) have equal timestamps as the audio 
payload.

There are codecs that split frames over several RTP packets. The sequence 
number increases, but the timestamp does not. (video codecs)



--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ia3be5834571ca18b68939abbcf1ce3a879156658
Gerrit-Change-Number: 39280
Gerrit-PatchSet: 5
Gerrit-Owner: falconia <fal...@freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: jolly <andr...@eversberg.eu>
Gerrit-CC: pespin <pes...@sysmocom.de>
Gerrit-Attention: falconia <fal...@freecalypso.org>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Tue, 19 Aug 2025 13:56:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to