Attention is currently required from: falconia. jolly has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email )
Change subject: bring twjit into libosmo-netif ...................................................................... Patch Set 5: (1 comment) File src/twjit.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/2bd3233b_02edda43?usp=email : PS5, Line 486: msgb_free(new_msg); > > Is there a twjit instance for every payload type or one for the complete > > RTP connection? […] It is ok for me to have a more specific de-jitter process, rather than something that solves all needs. I looked in my own de-jitter code and found the same. (drop sequence of frames with same time stamp) It makes sense, if only a voice stream (without telephone-events) are de-jittered. I looked into your RTP patch. The received RTP frame are directly sent to the jitter buffer. I suggest to split it, so the application can decide which frames are sent to the jitter buffer and which are not. Also it could decide not to use a jitter buffer at all. (when just doing RTP forwarding) -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia3be5834571ca18b68939abbcf1ce3a879156658 Gerrit-Change-Number: 39280 Gerrit-PatchSet: 5 Gerrit-Owner: falconia <fal...@freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: jolly <andr...@eversberg.eu> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: falconia <fal...@freecalypso.org> Gerrit-Comment-Date: Thu, 21 Aug 2025 12:01:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andr...@eversberg.eu> Comment-In-Reply-To: falconia <fal...@freecalypso.org>
