Attention is currently required from: falconia, jolly.

pespin has posted comments on this change by falconia. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email )

Change subject: bring twjit into libosmo-netif
......................................................................


Patch Set 5:

(2 comments)

File include/osmocom/netif/twjit.h:

https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/1191a356_97659d70?usp=email
 :
PS2, Line 137: bool osmo_twjit_got_any_input(struct osmo_twjit *twjit);
> I have warmed up to your idea of renaming this API, and I would like to 
> include the same rename in m […]
I'm fine with either of the two proposed.


File src/twjit.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/e240e539_8ae28ef9?usp=email
 :
PS2, Line 504:  rtph = osmo_rtp_get_hdr(msg);
> @pespin@sysmocom. […]
I mean dropping ortp completely. I dislike the idea of maintaing both ortp and 
twrtp.

Fine with the other stuff you mentioned.

Feel free to submit some RFC patch for osmo-bts in gerrit once you want to 
receive feedback.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ia3be5834571ca18b68939abbcf1ce3a879156658
Gerrit-Change-Number: 39280
Gerrit-PatchSet: 5
Gerrit-Owner: falconia <fal...@freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: jolly <andr...@eversberg.eu>
Gerrit-CC: pespin <pes...@sysmocom.de>
Gerrit-Attention: jolly <andr...@eversberg.eu>
Gerrit-Attention: falconia <fal...@freecalypso.org>
Gerrit-Comment-Date: Thu, 21 Aug 2025 11:30:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <fal...@freecalypso.org>
Comment-In-Reply-To: pespin <pes...@sysmocom.de>

Reply via email to