Attention is currently required from: falconia, jolly.

pespin has posted comments on this change by falconia. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email )

Change subject: bring twjit into libosmo-netif
......................................................................


Patch Set 5:

(1 comment)

File src/twjit.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/47567b20_09a9b82c?usp=email
 :
PS2, Line 504:  rtph = osmo_rtp_get_hdr(msg);
> Fair enough: I'll add this option to the next iteration of the present 
> patchset. […]
@fal...@freecalypso.org yes several people I know, not only you, (eg. me and 
@vyanits...@sysmocom.de) are happy to get rid of ortp dependency since it 
creates a lot of hassle to maintain, and yes, I was expecting you to submit a 
patch against osmo-bts to drop ortp and use twrtp instead (tbh I don't recall 
now if you already submitted that since a lot of time has happened?).

Now I hope you understand better my point regarding support M bit.
If we find more not envisioned problematic interop scenarios later on I'm sure 
we can extend twrtp out of that "closed-minded approach of emulating TDM" in 
order to get those fixed/improved. AFAIK nobody her anyway looked at full 
internals of ortp to make sure everything is 100% correct there.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ia3be5834571ca18b68939abbcf1ce3a879156658
Gerrit-Change-Number: 39280
Gerrit-PatchSet: 5
Gerrit-Owner: falconia <fal...@freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: jolly <andr...@eversberg.eu>
Gerrit-CC: pespin <pes...@sysmocom.de>
Gerrit-Attention: jolly <andr...@eversberg.eu>
Gerrit-Attention: falconia <fal...@freecalypso.org>
Gerrit-Comment-Date: Wed, 20 Aug 2025 15:38:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <fal...@freecalypso.org>
Comment-In-Reply-To: pespin <pes...@sysmocom.de>

Reply via email to