Attention is currently required from: fixeria, jolly, laforge, pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email )
Change subject: bring twjit into libosmo-netif ...................................................................... Patch Set 5: (1 comment) File src/twjit.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/8c26cfc3_e0067455?usp=email : PS2, Line 504: rtph = osmo_rtp_get_hdr(msg); > I wouldn't mind getting rid of ortp and switching to something else. […] Regarding the question of what to do in OsmoBTS, I really prefer to tackle that question *after* the present addition of twrtp to libosmo-netif is merged, not before. The present concern of extending libosmo-netif should be independent of what we ultimately decide to do in OsmoBTS. Now back to the original thread question of adding support for M bit in twjit: I am now ready to work on this task, and I have an additional question to @pes...@sysmocom.de. My current idea is to add the optional check of M bit to `check_input_for_subbuf()` function - I hope you'll agree it seems like the best place. The question is: should this M bit check go before or after the currently implemented `if (ts_delta < 0)` check? Consider this scenario: a packet comes in M bit set, but the timestamp is in the past relative to `head_ts`. Should the past timestamp take precedence (discard the packet as too old), or should the M bit take precedence and invoke reset in HUNT or handover in FLOWING? You might wish to consider scenarios in which marker and non-marker packets get reordered by the IP network, if such reordering is possible in those worlds where you say M bit handling is needed. >From my PoV, I treat this M bit handling as a customer-requested feature, and >you are the customer-like requestor - hence I need you to tell me exactly how >you want it to work. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia3be5834571ca18b68939abbcf1ce3a879156658 Gerrit-Change-Number: 39280 Gerrit-PatchSet: 5 Gerrit-Owner: falconia <fal...@freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: jolly <andr...@eversberg.eu> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Attention: jolly <andr...@eversberg.eu> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Thu, 21 Aug 2025 22:17:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <fal...@freecalypso.org> Comment-In-Reply-To: laforge <lafo...@osmocom.org> Comment-In-Reply-To: pespin <pes...@sysmocom.de>
