Attention is currently required from: daniel, fixeria, laforge, pespin.

osmith has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email )

Change subject: stp: Introduce tests to validate inaccessible SP scenario
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

File stp/STP_Tests_IPA.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525/comment/00bed74c_48215dc0?usp=email
 :
PS1, Line 654:  /* FIXME: DUNA doesn't exist in IPA. Sould we probably receive 
SCCP UDTS here? */
so it cannot fail here because of 
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41524/comment/5d1b0c3a_5c202908/

seems a bit weird at first, but still makes sense to add this I guess, so it 
could be extended in the future and so we can easily get into that code path 
from a test when working on it.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8aa3aa902eb56c982529d8c79b7f069145b2547d
Gerrit-Change-Number: 41525
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: daniel <[email protected]>
Gerrit-Comment-Date: Fri, 28 Nov 2025 13:42:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to