Attention is currently required from: daniel, fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email )
Change subject: stp: Introduce tests to validate inaccessible SP scenario ...................................................................... Patch Set 2: (1 comment) File stp/STP_Tests_M3UA.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525/comment/aad23743_c3224b83?usp=email : PS2, Line 207: "while waiting for ", msg)); IMHO the error messages are hard to understand. - the first message could mention that the message is unexpected within the timer - the second message has "while waiting for", but this function does the opposite, it waits for the timer to pass and checks that the message does *not* arrive I wonder if the msg parameter is even useful, couldn't it just ensure that no message arrives (except for the beat if answer_beat is true) until the timeout is done, and have one obvious error message saying that an unexpected message arrived before the timeout? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8aa3aa902eb56c982529d8c79b7f069145b2547d Gerrit-Change-Number: 41525 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Comment-Date: Mon, 01 Dec 2025 07:38:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
