Attention is currently required from: daniel, laforge, pespin.

fixeria has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email )

Change subject: stp: Introduce tests to validate inaccessible SP scenario
......................................................................


Patch Set 3:

(2 comments)

File stp/STP_Tests_IPA.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525/comment/6910d803_d49a94ee?usp=email
 :
PS3, Line 655: f_sleep(1.0);
> STP discards the message to be forwarded, since its destination is not 
> accessible.

But the testcase does not know whether the message has been discarded or not, 
right?


File stp/STP_Tests_M3UA.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525/comment/003590a9_b07f4ac1?usp=email
 :
PS3, Line 204: [] M3UA[idx].receive(t_M3UA_RecvFrom(?)) -> value rx
> Plus keeping answering for Hearbeats meanwhile to avoid failing due to other 
> reasons, etc.
I am fine with the Hearbeats, it's actually the two `M3UA[idx].receive` 
statements making this function look a bit weird. Not blocking though.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8aa3aa902eb56c982529d8c79b7f069145b2547d
Gerrit-Change-Number: 41525
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: daniel <[email protected]>
Gerrit-Comment-Date: Mon, 01 Dec 2025 11:45:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>

Reply via email to