Attention is currently required from: daniel, laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email )
Change subject: stp: Introduce tests to validate inaccessible SP scenario ...................................................................... Patch Set 3: (2 comments) File stp/STP_Tests_IPA.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525/comment/6128e0ac_8320044c?usp=email : PS3, Line 655: f_sleep(1.0); I am trying to understand what happens here. I see you're sending some data `f_IPA_send()` and then sleeping. What's expected to happen or not happen here? Please add a comment. File stp/STP_Tests_M3UA.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525/comment/ee03347e_7b89876e?usp=email : PS3, Line 204: [] M3UA[idx].receive(t_M3UA_RecvFrom(?)) -> value rx This function looks slightly overengineered. It boils down to failing on any M3UA PDU, right? And you have two distinct `M3UA[idx].receive` statements in order to have more precise verdict? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41525?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8aa3aa902eb56c982529d8c79b7f069145b2547d Gerrit-Change-Number: 41525 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Comment-Date: Mon, 01 Dec 2025 11:28:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
